netdev - Re: [PATCH v11 6/7] hwmon: Add Nuvoton NCT6694 HWMON support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0838e48b-c995-42f8-8803-18ed593a89ef@roeck-us.net>
Date: Fri, 23 May 2025 02:44:17 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Lee Jones <lee@...nel.org>, kernel test robot <lkp@...el.com>
Cc: a0282524688@...il.com, linus.walleij@...aro.org, brgl@...ev.pl,
 andi.shyti@...nel.org, mkl@...gutronix.de, mailhol.vincent@...adoo.fr,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, wim@...ux-watchdog.org,
 jdelvare@...e.com, alexandre.belloni@...tlin.com,
 oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-can@...r.kernel.org, netdev@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-rtc@...r.kernel.org, linux-usb@...r.kernel.org,
 Ming Yu <tmyu0@...oton.com>
Subject: Re: [PATCH v11 6/7] hwmon: Add Nuvoton NCT6694 HWMON support

On 5/23/25 02:00, Lee Jones wrote:
> On Wed, 21 May 2025, kernel test robot wrote:
> 
>> Hi,
>>
>> kernel test robot noticed the following build errors:
>>
>> [auto build test ERROR on andi-shyti/i2c/i2c-host]
>> [also build test ERROR on mkl-can-next/testing groeck-staging/hwmon-next abelloni/rtc-next linus/master lee-mfd/for-mfd-fixes v6.15-rc7]
>> [cannot apply to lee-mfd/for-mfd-next brgl/gpio/for-next next-20250516]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:    https://github.com/intel-lab-lkp/linux/commits/a0282524688-gmail-com/mfd-Add-core-driver-for-Nuvoton-NCT6694/20250520-100732
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
>> patch link:    https://lore.kernel.org/r/20250520020355.3885597-7-tmyu0%40nuvoton.com
>> patch subject: [PATCH v11 6/7] hwmon: Add Nuvoton NCT6694 HWMON support
>> config: i386-randconfig-013-20250521 (https://download.01.org/0day-ci/archive/20250521/202505210555.mud6jZoi-lkp@intel.com/config)
>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250521/202505210555.mud6jZoi-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202505210555.mud6jZoi-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> drivers/hwmon/nct6694-hwmon.c:12:10: fatal error: linux<mfd/core.h: No such file or directory
>>        12 | #include <linux<mfd/core.h>
> 
> This suggests that the set wasn't even build (let alone run) tested!
> 

Apparently. Guess that slipped in when they updated the copyright in the driver.
There is no other change since v9.

Otherwise the code looks good, though. With that fixed:

Reviewed-by: Guenter Roeck <linux@...ck-us.net>