[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202505231753.V7E84RiN-lkp@intel.com>
Date: Fri, 23 May 2025 17:44:57 +0800
From: kernel test robot <lkp@...el.com>
To: Linus Lüssing <linus.luessing@...3.blue>,
bridge@...ts.linux.dev
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
openwrt-devel@...ts.openwrt.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org,
Nikolay Aleksandrov <razor@...ckwall.org>,
Ido Schimmel <idosch@...dia.com>, Ivan Vecera <ivecera@...hat.com>,
Jiri Pirko <jiri@...nulli.us>, Vladimir Oltean <olteanv@...il.com>,
Andrew Lunn <andrew@...n.ch>, Jonathan Corbet <corbet@....net>,
Simon Horman <horms@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Kuniyuki Iwashima <kuniyu@...zon.com>,
Stanislav Fomichev <sdf@...ichev.me>,
Xiao Liang <shaw.leon@...il.com>,
Markus Stockhausen <markus.stockhausen@....de>,
Jan Hoffmann <jan.christian.hoffmann@...il.com>,
Birger Koblitz <git@...ger-koblitz.de>,
Bjørn Mork <bjorn@...k.no>,
Linus Lüssing <linus.luessing@...3.blue>
Subject: Re: [PATCH net-next 5/5] net: dsa: forward bridge/switchdev mcast
active notification
Hi Linus,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
[also build test ERROR on linus/master v6.15-rc7 next-20250523]
[cannot apply to net-next/main horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Linus-L-ssing/net-bridge-mcast-explicitly-track-active-state/20250523-040914
base: net/main
patch link: https://lore.kernel.org/r/20250522195952.29265-6-linus.luessing%40c0d3.blue
patch subject: [PATCH net-next 5/5] net: dsa: forward bridge/switchdev mcast active notification
config: s390-randconfig-001-20250523 (https://download.01.org/0day-ci/archive/20250523/202505231753.V7E84RiN-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250523/202505231753.V7E84RiN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505231753.V7E84RiN-lkp@intel.com/
All errors (new ones prefixed by >>):
net/dsa/user.c: In function 'dsa_user_port_attr_set':
>> net/dsa/user.c:661:3: error: a label can only be part of a statement and a declaration is not a statement
const bool *handled = ctx;
^~~~~
net/dsa/user.c: In function 'dsa_user_switchdev_event':
net/dsa/user.c:3770:3: error: a label can only be part of a statement and a declaration is not a statement
struct switchdev_notifier_port_attr_info *item = ptr;
^~~~~~
net/dsa/user.c: In function 'dsa_user_switchdev_blocking_event':
net/dsa/user.c:3813:3: error: a label can only be part of a statement and a declaration is not a statement
struct switchdev_notifier_port_attr_info *item = ptr;
^~~~~~
vim +661 net/dsa/user.c
598
599 static int dsa_user_port_attr_set(struct net_device *dev, const void *ctx,
600 const struct switchdev_attr *attr,
601 struct netlink_ext_ack *extack)
602 {
603 struct dsa_port *dp = dsa_user_to_port(dev);
604 int ret;
605
606 if (ctx && ctx != dp && attr->id != SWITCHDEV_ATTR_ID_BRIDGE_MC_ACTIVE)
607 return 0;
608
609 switch (attr->id) {
610 case SWITCHDEV_ATTR_ID_PORT_STP_STATE:
611 if (!dsa_port_offloads_bridge_port(dp, attr->orig_dev))
612 return -EOPNOTSUPP;
613
614 ret = dsa_port_set_state(dp, attr->u.stp_state, true);
615 break;
616 case SWITCHDEV_ATTR_ID_PORT_MST_STATE:
617 if (!dsa_port_offloads_bridge_port(dp, attr->orig_dev))
618 return -EOPNOTSUPP;
619
620 ret = dsa_port_set_mst_state(dp, &attr->u.mst_state, extack);
621 break;
622 case SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING:
623 if (!dsa_port_offloads_bridge_dev(dp, attr->orig_dev))
624 return -EOPNOTSUPP;
625
626 ret = dsa_port_vlan_filtering(dp, attr->u.vlan_filtering,
627 extack);
628 break;
629 case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME:
630 if (!dsa_port_offloads_bridge_dev(dp, attr->orig_dev))
631 return -EOPNOTSUPP;
632
633 ret = dsa_port_ageing_time(dp, attr->u.ageing_time);
634 break;
635 case SWITCHDEV_ATTR_ID_BRIDGE_MST:
636 if (!dsa_port_offloads_bridge_dev(dp, attr->orig_dev))
637 return -EOPNOTSUPP;
638
639 ret = dsa_port_mst_enable(dp, attr->u.mst, extack);
640 break;
641 case SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS:
642 if (!dsa_port_offloads_bridge_port(dp, attr->orig_dev))
643 return -EOPNOTSUPP;
644
645 ret = dsa_port_pre_bridge_flags(dp, attr->u.brport_flags,
646 extack);
647 break;
648 case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
649 if (!dsa_port_offloads_bridge_port(dp, attr->orig_dev))
650 return -EOPNOTSUPP;
651
652 ret = dsa_port_bridge_flags(dp, attr->u.brport_flags, extack);
653 break;
654 case SWITCHDEV_ATTR_ID_VLAN_MSTI:
655 if (!dsa_port_offloads_bridge_dev(dp, attr->orig_dev))
656 return -EOPNOTSUPP;
657
658 ret = dsa_port_vlan_msti(dp, &attr->u.vlan_msti);
659 break;
660 case SWITCHDEV_ATTR_ID_BRIDGE_MC_ACTIVE:
> 661 const bool *handled = ctx;
662
663 if (!dsa_port_offloads_bridge_dev(dp, attr->orig_dev))
664 return -EOPNOTSUPP;
665
666 ret = dsa_port_bridge_mdb_active(dp, attr->u.mc_active, extack,
667 *handled);
668 break;
669 default:
670 ret = -EOPNOTSUPP;
671 break;
672 }
673
674 return ret;
675 }
676
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists