netdev - Re: [PATCH iproute2] iproute2: bugfix - restore ip monitor backward compatibility.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMw=ZnQwuZm4jtJNSYzn5Nf-2dikvFWb2dt4ubX7nuFsCdgDqw@mail.gmail.com>
Date: Fri, 23 May 2025 11:25:41 +0100
From: Luca Boccassi <bluca@...ian.org>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org, 
	Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>, Adel Belhouane <bugs.a.b@...e.fr>
Subject: Re: [PATCH iproute2] iproute2: bugfix - restore ip monitor backward compatibility.

On Fri, 23 May 2025 at 04:25, Yuyang Huang <yuyanghuang@...gle.com> wrote:
>
> The current ip monitor implementation fails on older kernels that lack
> newer RTNLGRP_* definitions. As ip monitor is expected to maintain
> backward compatibility, this commit updates the code to check if errno
> is not EINVAL when rtnl_add_nl_group() fails. This change restores ip
> monitor's backward compatibility with older kernel versions.
>
> Cc: David Ahern <dsahern@...nel.org>
> Cc: Luca Boccassi <bluca@...ian.org>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Reported-by: Adel Belhouane <bugs.a.b@...e.fr>
> Closes: https://lore.kernel.org/netdev/CADXeF1GgJ_1tee3hc7gca2Z21Lyi3mzxq52sSfMg3mFQd2rGWQ@mail.gmail.com/T/#t
> Signed-off-by: Yuyang Huang <yuyanghuang@...gle.com>
> ---
>  ip/ipmonitor.c | 35 ++++++++++++++++++++++-------------
>  1 file changed, 22 insertions(+), 13 deletions(-)

Thanks, can confirm this fixes the problem and ip monitor works again
with v6.12.

Tested-by: Luca Boccassi <bluca@...ian.org>