netdev - Re: [PATCH v11 net-next 3/8] net: ena: Add device reload capability through devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33wxyme5ngstfdq4aycta7ilxhjcn4nbf5ewa24kcm6zaw5ddx@637xcbjknc6l>
Date: Mon, 26 May 2025 11:51:14 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: David Arinzon <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Richard Cochran <richardcochran@...il.com>, "Woodhouse, David" <dwmw@...zon.com>, 
	"Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, 
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, 
	"Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>, 
	"Schmeilin, Evgeny" <evgenys@...zon.com>, "Belgazal, Netanel" <netanel@...zon.com>, 
	"Saidi, Ali" <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>, 
	"Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, 
	"Bernstein, Amit" <amitbern@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, 
	"Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>, 
	"Machnikowski, Maciek" <maciek@...hnikowski.net>, Rahul Rameshbabu <rrameshbabu@...dia.com>, 
	Gal Pressman <gal@...dia.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Andrew Lunn <andrew@...n.ch>, Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH v11 net-next 3/8] net: ena: Add device reload capability
 through devlink

Mon, May 26, 2025 at 08:09:13AM +0200, darinzon@...zon.com wrote:

[..]

>+static int ena_devlink_reload_down(struct devlink *devlink,
>+				   bool netns_change,
>+				   enum devlink_reload_action action,
>+				   enum devlink_reload_limit limit,
>+				   struct netlink_ext_ack *extack)
>+{
>+	struct ena_adapter *adapter = ENA_DEVLINK_PRIV(devlink);
>+
>+	if (netns_change) {
>+		NL_SET_ERR_MSG_MOD(extack,
>+				   "Namespace change is not supported");
>+		return -EOPNOTSUPP;
>+	}
>+
>+	if (action != DEVLINK_RELOAD_ACTION_DRIVER_REINIT) {
>+		NL_SET_ERR_MSG_MOD(extack,
>+				   "Action is not supported");

Why you need this check? devlink_reload_action_is_supported() is
checking that in devlink_nl_reload_doit()



>+		return -EOPNOTSUPP;
>+	}
>+	if (limit != DEVLINK_RELOAD_LIMIT_UNSPEC) {
>+		NL_SET_ERR_MSG_MOD(extack,
>+				   "Driver reload doesn't support limitations");

Same here.


>+		return -EOPNOTSUPP;
>+	}
>+
>+	rtnl_lock();
>+	ena_destroy_device(adapter, false);
>+	rtnl_unlock();
>+
>+	return 0;
>+}

[..]