netdev - Re: [PATCH v11 net-next 0/8] PHC support in ENA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jdkiblbwiut4x7t7gtpiatdbiueehvhuqdhn5caoj2ijiil2yr@6xof3oyhruxa>
Date: Mon, 26 May 2025 11:53:14 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: David Arinzon <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Richard Cochran <richardcochran@...il.com>, "Woodhouse, David" <dwmw@...zon.com>, 
	"Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, 
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, 
	"Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>, 
	"Schmeilin, Evgeny" <evgenys@...zon.com>, "Belgazal, Netanel" <netanel@...zon.com>, 
	"Saidi, Ali" <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>, 
	"Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, 
	"Bernstein, Amit" <amitbern@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, 
	"Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>, 
	"Machnikowski, Maciek" <maciek@...hnikowski.net>, Rahul Rameshbabu <rrameshbabu@...dia.com>, 
	Gal Pressman <gal@...dia.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Andrew Lunn <andrew@...n.ch>, Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH v11 net-next 0/8] PHC support in ENA driver

Mon, May 26, 2025 at 08:09:10AM +0200, darinzon@...zon.com wrote:
>Changes in v11
>- Change PHC enablement devlink parameter to be generic instead of device specific
>
>Changes in v10 (https://lore.kernel.org/netdev/20250522134839.1336-1-darinzon@amazon.com/):
>- Remove error checks for debugfs calls
>
>Changes in v9 (https://lore.kernel.org/netdev/20250521114254.369-1-darinzon@amazon.com/):
>- Use devlink instead of sysfs for PHC enablement
>- Use debugfs instead of sysfs for PHC stats
>- Add PHC error flags and break down phc_err into two errors
>- Various style changes
>
>Changes in v8 (https://lore.kernel.org/netdev/20250304190504.3743-1-darinzon@amazon.com/):
>- Create a sysfs entry for each PHC stat
>
>Changes in v7 (https://lore.kernel.org/netdev/20250218183948.757-1-darinzon@amazon.com/):
>- Move PHC stats to sysfs
>- Add information about PHC enablement
>- Remove unrelated style changes
>
>Changes in v6 (https://lore.kernel.org/netdev/20250206141538.549-1-darinzon@amazon.com/):
>- Remove PHC error bound
>
>Changes in v5 (https://lore.kernel.org/netdev/20250122102040.752-1-darinzon@amazon.com/):
>- Add PHC error bound
>- Add PHC enablement and error bound retrieval through sysfs
>
>Changes in v4 (https://lore.kernel.org/netdev/20241114095930.200-1-darinzon@amazon.com/):
>- Minor documentation change (resolution instead of accuracy)
>
>Changes in v3 (https://lore.kernel.org/netdev/20241103113140.275-1-darinzon@amazon.com/):
>- Resolve a compilation error
>
>Changes in v2 (https://lore.kernel.org/netdev/20241031085245.18146-1-darinzon@amazon.com/):
>- CCd PTP maintainer
>- Fixed style issues
>- Fixed documentation warning
>
>v1 (https://lore.kernel.org/netdev/20241021052011.591-1-darinzon@amazon.com/)
>
>This patchset adds the support for PHC (PTP Hardware Clock)
>in the ENA driver. The documentation part of the patchset
>includes additional information, including statistics,
>utilization and invocation examples through the testptp
>utility.
>
>David Arinzon (8):
>  net: ena: Add PHC support in the ENA driver
>  net: ena: PHC silent reset
>  net: ena: Add device reload capability through devlink
>  devlink: Add new "enable_phc" generic device param
>  net: ena: Control PHC enable through devlink
>  net: ena: Add debugfs support to the ENA driver
>  net: ena: View PHC stats using debugfs
>  net: ena: Add PHC documentation

Could you please add very simple devlink_port instance of flavour
PHYSICAL and link it with netdev? Having devlink instance without the
port related to the netdev looks a bit odd.

Thanks!