[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aDQgmJMIkkQ922Bd@shell.armlinux.org.uk>
Date: Mon, 26 May 2025 09:04:40 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: James Hilliard <james.hilliard1@...il.com>
Cc: netdev@...r.kernel.org, linux-sunxi@...ts.linux.dev,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Yinggang Gu <guyinggang@...ngson.cn>,
Huacai Chen <chenhuacai@...nel.org>,
Yanteng Si <si.yanteng@...ux.dev>,
Feiyang Chen <chenfeiyang@...ngson.cn>,
Uwe Kleine-König <u.kleine-koenig@...libre.com>,
Jinjie Ruan <ruanjinjie@...wei.com>,
Paul Kocialkowski <paulk@...-base.io>,
linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] net: stmmac: dwmac-sun8i: Allow runtime
AC200/AC300 phy selection
On Sun, May 25, 2025 at 06:29:22PM -0600, James Hilliard wrote:
> + if (!nvmem_cell_read_u16(dev, "ac300", &val)) {
> + const char *phy_name = (val & AC300_KEY) ? "ac300" : "ac200";
> + int index = of_property_match_string(dev->of_node, "phy-names", phy_name);
> + if (index < 0) {
> + dev_err(dev, "PHY name not found in device tree\n");
> + return -EINVAL;
> + }
> +
> + plat_dat->phy_node = of_parse_phandle(dev->of_node, "phys", index);
> + if (!plat_dat->phy_node) {
> + dev_err(dev, "Failed to get PHY node from phys property\n");
> + return -EINVAL;
> + }
> + }
1. You are re-using the drivers/phy binding for ethernet PHYs driven by
phylib here.
2. You need to update
Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
in a separate patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists