netdev - Re: Poor thunderbolt-net interface performance when bridged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CD0896D8-941E-403E-9DA9-51B13604A449@bejarano.io>
Date: Tue, 27 May 2025 21:32:38 +0200
From: Ricard Bejarano <ricard@...arano.io>
To: Andrew Lunn <andrew@...n.ch>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 netdev@...r.kernel.org,
 michael.jamet@...el.com,
 YehezkelShB@...il.com,
 andrew+netdev@...n.ch,
 davem@...emloft.net,
 edumazet@...gle.com,
 kuba@...nel.org,
 pabeni@...hat.com
Subject: Re: Poor thunderbolt-net interface performance when bridged

Also, I'm doing this instead:

diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c
index 0a53ec293..3cd72aa2d 100644
--- a/drivers/net/thunderbolt/main.c
+++ b/drivers/net/thunderbolt/main.c
@@ -1116,6 +1116,8 @@ static netdev_tx_t tbnet_start_xmit(struct sk_buff *skb,
        bool unmap = false;
        void *dest;
 
+       skb_linearize(skb);
+
        trace_tbnet_tx_skb(skb);
 
        nframes = DIV_ROUND_UP(data_len, TBNET_MAX_PAYLOAD_SIZE);

skb_linearize already checks if skb is non-linear, and if so, it linearizes it
directly without copying.

RB