netdev - Re: [PATCH] gve: Fix RX_BUFFERS_POSTED stat to report per-queue fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEAWyHfES0EepFr7Bm+BO6KXw1rNy9_7zv+Jk+rJadkGvdYgqg@mail.gmail.com>
Date: Tue, 27 May 2025 16:46:39 -0700
From: Harshitha Ramamurthy <hramamurthy@...gle.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: ziweixiao@...gle.com, joshwash@...gle.com, willemb@...gle.com, 
	pkaligineedi@...gle.com, pabeni@...hat.com, kuba@...nel.org, 
	jeroendb@...gle.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	darren.kenny@...cle.com
Subject: Re: [PATCH] gve: Fix RX_BUFFERS_POSTED stat to report per-queue fill_cnt

On Tue, May 27, 2025 at 6:08 AM Alok Tiwari <alok.a.tiwari@...cle.com> wrote:
>
> Previously, the RX_BUFFERS_POSTED stat incorrectly reported the
> fill_cnt from RX queue 0 for all queues, resulting in inaccurate
> per-queue statistics.
> Fix this by correctly indexing priv->rx[idx].fill_cnt for each RX queue.
>
> Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/net/ethernet/google/gve/gve_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch looks okay, but it needs to be prefixed with [PATCH net] since
it's a fix.

Thanks,
Harshitha
>
> diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
> index c3791cf23c87..d561d45021a5 100644
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c
> @@ -2153,7 +2153,7 @@ void gve_handle_report_stats(struct gve_priv *priv)
>                         };
>                         stats[stats_idx++] = (struct stats) {
>                                 .stat_name = cpu_to_be32(RX_BUFFERS_POSTED),
> -                               .value = cpu_to_be64(priv->rx[0].fill_cnt),
> +                               .value = cpu_to_be64(priv->rx[idx].fill_cnt),
>                                 .queue_id = cpu_to_be32(idx),
>                         };
>                 }
> --
> 2.47.1
>