netdev - RE: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS8PR07MB7973CF0C34C90A2A91C36A80A367A@AS8PR07MB7973.eurprd07.prod.outlook.com>
Date: Wed, 28 May 2025 07:26:48 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
CC: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "corbet@....net"
	<corbet@....net>, "horms@...nel.org" <horms@...nel.org>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "kuniyu@...zon.com" <kuniyu@...zon.com>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "donald.hunter@...il.com"
	<donald.hunter@...il.com>, "ast@...erby.net" <ast@...erby.net>,
	"liuhangbin@...il.com" <liuhangbin@...il.com>, "shuah@...nel.org"
	<shuah@...nel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "ij@...nel.org" <ij@...nel.org>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, g.white <g.white@...lelabs.com>,
	"ingemar.s.johansson@...csson.com" <ingemar.s.johansson@...csson.com>,
	"mirja.kuehlewind@...csson.com" <mirja.kuehlewind@...csson.com>,
	"cheshire@...le.com" <cheshire@...le.com>, "rs.ietf@....at" <rs.ietf@....at>,
	"Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>, vidhi_goel
	<vidhi_goel@...le.com>
Subject: RE: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option

> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com> 
> Sent: Tuesday, May 20, 2025 3:38 PM
> To: Eric Dumazet <edumazet@...gle.com>; Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
> Cc: linux-doc@...r.kernel.org; corbet@....net; horms@...nel.org; dsahern@...nel.org; kuniyu@...zon.com; bpf@...r.kernel.org; netdev@...r.kernel.org; dave.taht@...il.com; jhs@...atatu.com; kuba@...nel.org; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; andrew+netdev@...n.ch; donald.hunter@...il.com; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white <g.white@...lelabs.com>; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel <vidhi_goel@...le.com>
> Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> On 5/20/25 12:32 PM, Eric Dumazet wrote:
> > On Tue, May 20, 2025 at 2:31 AM Paolo Abeni <pabeni@...hat.com> wrote:
> >>
> >> On 5/14/25 3:56 PM, chia-yu.chang@...ia-bell-labs.com wrote:
> >>> This patch uses the existing 1-byte holes in the tcp_sock_write_txrx 
> >>> group for new u8 members, but adds a 4-byte hole in 
> >>> tcp_sock_write_rx group after the new u32 delivered_ecn_bytes[3] 
> >>> member. Therefore, the group size of tcp_sock_write_rx is increased from 96 to 112.
> >>
> >> Note that I'm still concerned by the relevant increase of the 
> >> cacheline groups size. My fear is that this change could defeat 
> >> some/most of the benefist from the cacheline reorg for all tcp users.
> >>
> >> Some additional feedback from Eric and/or Neal more than welcome!
> >
> > I have been trapped lately with production issues, sorry for the delay.
> >
> > I am still working on an idpf bug, hopefully done today.
> >
> > Then, I am OOO tomorrow, and can have a look at the whole series on Thursday.
> 
> Thanks Eric!
> 
> @Chia-Yu: please consider the above timeline before posting a new revision. i.e. it would be likely wise to wait for the additional review.
>
> /P

Hi Eric and Paolo,

As you know that the merge window for v6.16 is begun and net-next is closed for new features till 9th of June.

May I ask did you manage yo review the patches we sent two weeks ago? 

Thanks.

Best Regards,
Chia-Yu