netdev - Re: [PATCH] sctp: mark sctp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250528130445.391f90ca@pumpkin>
Date: Wed, 28 May 2025 13:04:45 +0100
From: David Laight <david.laight.linux@...il.com>
To: Xin Long <lucien.xin@...il.com>
Cc: Benjamin Poirier <benjamin.poirier@...il.com>, Christoph Hellwig
 <hch@....de>, marcelo.leitner@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 linux-sctp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sctp: mark sctp_do_peeloff static

On Tue, 27 May 2025 10:23:37 -0400
Xin Long <lucien.xin@...il.com> wrote:

> On Mon, May 26, 2025 at 3:38 PM Benjamin Poirier
> <benjamin.poirier@...il.com> wrote:
> >
> > On 2025-05-26 14:25 -0400, Xin Long wrote:  
> > > On Mon, May 26, 2025 at 1:47 AM Christoph Hellwig <hch@....de> wrote:  
> > > >
> > > > sctp_do_peeloff is only used inside of net/sctp/socket.c,
> > > > so mark it static.
...

> > I don't see a problem with marking sctp_do_peeloff() static again.
> >  
> > > While there’s no known in-tree usage beyond SCTP itself, we can’t be
> > > sure whether this function has been used by out-of-tree kernel modules.  
> >
> > The mainline kernel does not need to cater to out-of-tree users.  
> Thank you for chiming in.
> 
> I didn't know it was exported for the in-tree kernel dlm, and this
> patch should be applied to net-next.

The most likely module use would be bpf or io_uring.
But they'd probably end up using the sockopt interface (the same
as applications).

Mind you 'peeloff' is all a strange idea that seems (to me) solving
a problem that has nothing at all to do with sctp (as a protocol).
The entire 'many-to-one' seems to be there to avoid the overhead
of a lot of sockets when the data data is low.
I'm sure epoll() solves the actual problem.

	David