netdev - Re: [net v2 PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250528125501.GC365796@horms.kernel.org>
Date: Wed, 28 May 2025 13:55:01 +0100
From: Simon Horman <horms@...nel.org>
To: Subbaraya Sundeep <sbhatta@...vell.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, saikrishnag@...vell.com,
	gakula@...vell.com, hkelam@...vell.com, sgoutham@...vell.com,
	lcherian@...vell.com, bbhushan2@...vell.com, jerinj@...vell.com,
	netdev@...r.kernel.org
Subject: Re: [net v2 PATCH] octeontx2-pf: Avoid typecasts by simplifying
 otx2_atomic64_add macro

On Tue, May 27, 2025 at 03:33:00PM +0530, Subbaraya Sundeep wrote:
> Just because otx2_atomic64_add is using u64 pointer as argument
> all callers has to typecast __iomem void pointers which inturn
> causing sparse warnings. Fix those by changing otx2_atomic64_add
> argument to void pointer.

I'm wondering if you considered changing the type of the 2nd parameter
of otx2_atomic64_add to u64 __iomem * and, correspondingly, the type
of the local variables updated by this patch. Perhaps that isn't so
clean for some reason. But if it can be done cleanly it does seem slightly
nicer to me.

> 
> Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")

I do appreciate this change. But I wonder if it is more of a
clean-up for net-next (once it re-opens, no Fixes tag) than
a fix.

> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> ---
> v2:
>  Fixed x86 build error of void pointer dereference reported by
>  kernel test robot

...