netdev - Re: [PATCH] netlink: avoid extra pskb_expand_head() in netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250528174355.2333a83a@kernel.org>
Date: Wed, 28 May 2025 17:43:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: avoid extra pskb_expand_head() in
 netlink_trim()

On Wed, 28 May 2025 18:36:28 +0300 Dmitry Antipov wrote:
> When 'netlink_trim()' processes shared skb, using 'skb_clone()' with
> following 'pskb_expand_head()' looks suboptimal, and it's expected to
> be a bit faster to do 'skb_copy_expand()' with desired tailroom instead.

Looks fine, but it would be useful to add more info about the practical
scenario where this patch makes a difference.

Other than that - net-next is closed, please repost after the merge
window.
-- 
pw-bot: defer