netdev - Re: [PATCH v2 net] net/mlx4_en: Prevent potential integer overflow calculating Hz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174851582800.3224950.5138416129241395167.git-patchwork-notify@kernel.org>
Date: Thu, 29 May 2025 10:50:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: eugenia@...lanox.com, tariqt@...dia.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 ogerlitz@...lanox.com, matanb@...lanox.com, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net] net/mlx4_en: Prevent potential integer overflow
 calculating Hz

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 28 May 2025 11:11:09 +0300 you wrote:
> The "freq" variable is in terms of MHz and "max_val_cycles" is in terms
> of Hz.  The fact that "max_val_cycles" is a u64 suggests that support
> for high frequency is intended but the "freq_khz * 1000" would overflow
> the u32 type if we went above 4GHz.  Use unsigned long long type for the
> mutliplication to prevent that.
> 
> Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> [...]

Here is the summary with links:
  - [v2,net] net/mlx4_en: Prevent potential integer overflow calculating Hz
    https://git.kernel.org/netdev/net/c/54d34165b4f7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html