netdev - Re: [PATCH net] selftests: net: build net/lib dependency in all target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06e27b37-1d70-4e93-bd12-05e3222adeee@gmail.com>
Date: Thu, 29 May 2025 21:18:46 +0700
From: Bui Quang Minh <minhquangbui99@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
 Philip Li <philip.li@...el.com>, oliver.sang@...el.com,
 Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: build net/lib dependency in all
 target

On 5/29/25 20:34, Simon Horman wrote:
> On Thu, May 29, 2025 at 06:04:17PM +0700, Bui Quang Minh wrote:
>> On 5/29/25 17:32, Simon Horman wrote:
>>> On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
>>>> Currently, we only build net/lib dependency in install target. This
>>>> commit moves that to all target so that net/lib is included in in-tree
>>>> build and run_tests.
>>> Hi,
>>>
>>> The above describes what is being done.
>>> I think it would be good to also describe why.
>> Hi,
>>
>> Currently, when building net related selftests, we need to
>>
>>      make install
>>
>> so that the net/lib is compiled. In case we do
>>
>>      make
>>
>> or
>>
>>      make run_tests
>>
>> the net/lib is not compiled. So I move the INSTALL_DEP_TARGETS which is
>> net/lib if the selftests is net related to all. As a result, all make/make
>> install/make run_tests will have the net/lib compiled.
> Thanks for the explanation, it is much appreciated.
>
> I think it would be good to include something along those lines
> in the commit message of the patch.
>
> Please note, that if you post a v2, before doing so you should allow 24h to
> elapse since the posting of v1.
>
> https://docs.kernel.org/process/maintainer-netdev.html

Thanks for your review and for pointing me the document.

Quang Minh.