lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250528184948.5d85f0cc@kernel.org>
Date: Wed, 28 May 2025 18:49:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Sunil Goutham
 <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>, Geetha
 sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>, Subbaraya
 Sundeep <sbhatta@...vell.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Ratheesh Kannoth <rkannoth@...vell.com>, Simon
 Horman <horms@...nel.org>
Subject: Re: [net] Octeontx2-af: Skip overlap check for SPI field

On Sun, 25 May 2025 15:28:54 +0530 Hariprasad Kelam wrote:
> Currently, the AF driver scans the mkex profile to identify all
> supported features. This process also involves checking for any
> fields that might overlap with each other.
> 
> For example, NPC_TCP_SPORT field offset within the key should
> not overlap with NPC_DMAC/NPC_SIP_IPV4 or any other field.
> 
> However, there are situations where some overlap is unavoidable.
> For instance, when extracting the SPI field, the same key offset might
> be used by both the AH and ESP layers. This patch addresses this
> specific scenario by skipping the overlap check and instead, adds
> a warning message to the user.

The commit message doesn't really explain what the implications for
field overlap are. The warning is also very uninformative. The user
will see the warning, find the commit which added it, and should be
able to more or less figure out what the implications are.
-- 
pw-bot: cr

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ