netdev - Re: [PATCH] net: af_key: Add error check in set_sadb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250528185346.4eebf434@kernel.org>
Date: Wed, 28 May 2025 18:53:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] net: af_key: Add error check in set_sadb_address()

On Sun, 25 May 2025 23:53:50 +0800 Wentao Liang wrote:
> The function set_sadb_address() calls the function
> pfkey_sockaddr_fill(), but does not check its return value.
> A proper implementation can be found in set_sadb_kmaddress().
> 
> Add an error check for set_sadb_address(), return error code
> if the function fails.

Please look at the callers, and you'll find out that the family has
already been validated.
-- 
pw-bot: reject