netdev - Re: [PATCH] net: dsa: tag_brcm: legacy: fix pskb_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90e91a4f-56de-421d-8e4d-1e641a2ad430@broadcom.com>
Date: Thu, 29 May 2025 14:46:16 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Álvaro Fernández Rojas <noltari@...il.com>,
 florian.fainelli@...adcom.com, jonas.gorski@...il.com, dgcbueu@...il.com,
 andrew@...n.ch, olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: tag_brcm: legacy: fix pskb_may_pull length



On 5/29/2025 5:44 AM, Álvaro Fernández Rojas wrote:
> BRCM_LEG_PORT_ID was incorrectly used for pskb_may_pull length.
> The correct check is BRCM_LEG_TAG_LEN + VLAN_HLEN, or 10 bytes.
> 
> Fixes: 964dbf186eaa ("net: dsa: tag_brcm: add support for legacy tags")
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian