netdev - Re: [Intel-wired-lan] [PATCH iwl-next v3 4/7] igc: assign highest TX queue number as highest priority in mqprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f401d386-3ee0-4f15-b20e-d83623d2975d@intel.com>
Date: Thu, 29 May 2025 10:21:12 +0300
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: "Abdul Rahim, Faizal" <faizal.abdul.rahim@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean
	<vladimir.oltean@....com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Simon Horman <horms@...nel.org>, Faizal Rahim
	<faizal.abdul.rahim@...ux.intel.com>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, Chwee-Lin Choong
	<chwee.lin.choong@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 4/7] igc: assign highest TX
 queue number as highest priority in mqprio

On 19/05/2025 10:19, Abdul Rahim, Faizal wrote:
> From: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
> 
> Previously, TX arbitration prioritized queues based on the TC they were
> mapped to. A queue mapped to TC 3 had higher priority than one mapped to
> TC 0.
> 
> To improve code reuse for upcoming patches and align with typical NIC
> behavior, this patch updates the logic to prioritize higher queue numbers
> when mqprio is used. As a result, queue 0 becomes the lowest priority and
> queue 3 becomes the highest.
> 
> This patch also introduces igc_tsn_is_tc_to_queue_priority_ordered() to
> preserve the original TC-based priority rule and reject configurations
> where a higher TC maps to a lower queue offset.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 19 ++++++++++++
>   drivers/net/ethernet/intel/igc/igc_tsn.c  | 35 ++++++++++++++---------
>   2 files changed, 41 insertions(+), 13 deletions(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>