| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250530-rss-v12-9-95d8b348de91@daynix.com>
Date: Fri, 30 May 2025 13:50:13 +0900
From: Akihiko Odaki <akihiko.odaki@...nix.com>
To: Jonathan Corbet <corbet@....net>,
Willem de Bruijn <willemdebruijn.kernel@...il.com>,
Jason Wang <jasowang@...hat.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Shuah Khan <shuah@...nel.org>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, kvm@...r.kernel.org,
virtualization@...ts.linux-foundation.org, linux-kselftest@...r.kernel.org,
Yuri Benditovich <yuri.benditovich@...nix.com>,
Andrew Melnychenko <andrew@...nix.com>,
Stephen Hemminger <stephen@...workplumber.org>, gur.stavi@...wei.com,
Lei Yang <leiyang@...hat.com>, Simon Horman <horms@...nel.org>,
Akihiko Odaki <akihiko.odaki@...nix.com>
Subject: [PATCH net-next v12 09/10] selftest: tap: Add tests for virtio-net
ioctls
They only test the ioctls are wired up to the implementation common with
tun as it is already tested for tun.
Signed-off-by: Akihiko Odaki <akihiko.odaki@...nix.com>
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/tap.c | 131 ++++++++++++++++++++++++++++++++++++-
2 files changed, 129 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index 61e5116987f3..00cb1e65b392 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -99,6 +99,7 @@ CONFIG_IPV6_IOAM6_LWTUNNEL=y
CONFIG_CRYPTO_SM4_GENERIC=y
CONFIG_AMT=m
CONFIG_TUN=y
+CONFIG_TUN_VNET_CROSS_LE=y
CONFIG_VXLAN=m
CONFIG_IP_SCTP=m
CONFIG_NETFILTER_XT_MATCH_POLICY=m
diff --git a/tools/testing/selftests/net/tap.c b/tools/testing/selftests/net/tap.c
index 247c3b3ac1c9..0decbc338965 100644
--- a/tools/testing/selftests/net/tap.c
+++ b/tools/testing/selftests/net/tap.c
@@ -387,9 +387,6 @@ FIXTURE_TEARDOWN(tap)
if (self->fd != -1)
close(self->fd);
- ret = dev_delete(param_dev_tap_name);
- EXPECT_EQ(ret, 0);
-
ret = dev_delete(param_dev_dummy_name);
EXPECT_EQ(ret, 0);
}
@@ -431,4 +428,132 @@ TEST_F(tap, test_packet_crash_tap_invalid_eth_proto)
ASSERT_EQ(errno, EINVAL);
}
+TEST_F(tap, test_vnethdrsz)
+{
+ int sz = sizeof(struct virtio_net_hdr_v1_hash);
+
+ ASSERT_FALSE(dev_delete(param_dev_tap_name));
+
+ ASSERT_FALSE(ioctl(self->fd, TUNSETVNETHDRSZ, &sz));
+ sz = 0;
+ ASSERT_FALSE(ioctl(self->fd, TUNGETVNETHDRSZ, &sz));
+ EXPECT_EQ(sizeof(struct virtio_net_hdr_v1_hash), sz);
+}
+
+TEST_F(tap, test_vnetle)
+{
+ int le = 1;
+
+ ASSERT_FALSE(dev_delete(param_dev_tap_name));
+
+ ASSERT_FALSE(ioctl(self->fd, TUNSETVNETLE, &le));
+ le = 0;
+ ASSERT_FALSE(ioctl(self->fd, TUNGETVNETLE, &le));
+ EXPECT_EQ(1, le);
+}
+
+TEST_F(tap, test_vnetbe)
+{
+ int be = 1;
+ int ret;
+
+ ASSERT_FALSE(dev_delete(param_dev_tap_name));
+
+ ret = ioctl(self->fd, TUNSETVNETBE, &be);
+ if (ret == -1 && errno == EINVAL)
+ SKIP(return, "TUNSETVNETBE not supported");
+
+ ASSERT_FALSE(ret);
+ be = 0;
+ ASSERT_FALSE(ioctl(self->fd, TUNGETVNETBE, &be));
+ EXPECT_EQ(1, be);
+}
+
+TEST_F(tap, test_getvnethashtypes)
+{
+ uint32_t hash_types;
+ int ret;
+
+ ASSERT_FALSE(dev_delete(param_dev_tap_name));
+
+ ret = ioctl(self->fd, TUNGETVNETHASHTYPES, &hash_types);
+ if (ret == -1 && errno == EINVAL)
+ SKIP(return, "TUNGETVNETHASHTYPES not supported");
+
+ EXPECT_FALSE(ret);
+}
+
+FIXTURE(tap_setvnethash)
+{
+ int fd;
+};
+
+FIXTURE_VARIANT(tap_setvnethash)
+{
+ unsigned int cmd;
+};
+
+FIXTURE_VARIANT_ADD(tap_setvnethash, reportingautomq)
+{
+ .cmd = TUNSETVNETREPORTINGAUTOMQ
+};
+
+FIXTURE_VARIANT_ADD(tap_setvnethash, reportingrss)
+{
+ .cmd = TUNSETVNETREPORTINGRSS
+};
+
+FIXTURE_VARIANT_ADD(tap_setvnethash, rss)
+{
+ .cmd = TUNSETVNETRSS
+};
+
+FIXTURE_SETUP(tap_setvnethash)
+{
+ int ret;
+
+ ret = dev_create(param_dev_dummy_name, "dummy", NULL, NULL);
+ ASSERT_FALSE(ret);
+
+ ret = dev_create(param_dev_tap_name, "macvtap", macvtap_fill_rtattr,
+ NULL);
+ ASSERT_FALSE(ret)
+ EXPECT_FALSE(dev_delete(param_dev_dummy_name));
+
+ self->fd = opentap(param_dev_tap_name);
+ ASSERT_LT(0, self->fd)
+ EXPECT_FALSE(dev_delete(param_dev_dummy_name));
+}
+
+FIXTURE_TEARDOWN(tap_setvnethash)
+{
+ EXPECT_FALSE(close(self->fd));
+ EXPECT_FALSE(dev_delete(param_dev_dummy_name));
+}
+
+TEST_F(tap_setvnethash, test_alive)
+{
+ struct tun_vnet_rss rss = { .hash_types = 0 };
+ int ret;
+
+ ret = ioctl(self->fd, variant->cmd, &rss);
+
+ if (ret == -1 && errno == EINVAL)
+ SKIP(return, "not supported");
+
+ EXPECT_FALSE(ret);
+}
+
+TEST_F(tap_setvnethash, test_deleted)
+{
+ ASSERT_FALSE(dev_delete(param_dev_tap_name));
+
+ ASSERT_EQ(-1, ioctl(self->fd, variant->cmd));
+
+ if (errno == EINVAL)
+ SKIP(return, "not supported");
+
+ EXPECT_EQ(EBADFD, errno);
+}
+
TEST_HARNESS_MAIN
--
2.49.0
Powered by blists - more mailing lists