netdev - Re: [PATCH v12 04/10] ref_tracker: have callers pass output function to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vzuwl22qfx5pkcgliy3n76mqx4od2dtbduga4wl4tlvtae63e3@vnzosrktvg5m>
Date: Fri, 30 May 2025 11:13:08 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	Qasim Ijaz <qasdev00@...il.com>, Nathan Chancellor <nathan@...nel.org>,
	Andrew Lunn <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH v12 04/10] ref_tracker: have callers pass output function
 to pr_ostream()

Hi Jeff,

[...]
> +static void __ostream_printf pr_ostream_buf(struct ostream *stream, char *fmt, ...)
> +{
> +	int ret, len = stream->size - stream->used;
> +	va_list args;
> +
> +	va_start(args, fmt);
> +	ret = vsnprintf(stream->buf + stream->used, len, fmt, args);
vsnprintf() technically may return a negative error code.
In that case, we'd be adding some unwanted values to the
stream->used. When we encounter an error we could skip
modifying that field.

> +	va_end(args);
> +	stream->used += min(ret, len);
> +}
> +
[...]

Best Regardsm
Krzysztof