netdev - RE: [PATCH bpf v2] xsk: Fix out of order segment free in __xsk_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250530115635eucms1p43454c8aa2f2215d2b86bc41ee9d1085e@eucms1p4>
Date: Fri, 30 May 2025 13:56:35 +0200
From: Eryk Kubanski <e.kubanski@...tner.samsung.com>
To: Eryk Kubanski <e.kubanski@...tner.samsung.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "bjorn@...nel.org" <bjorn@...nel.org>, "magnus.karlsson@...el.com"
	<magnus.karlsson@...el.com>, "maciej.fijalkowski@...el.com"
	<maciej.fijalkowski@...el.com>, "jonathan.lemon@...il.com"
	<jonathan.lemon@...il.com>
Subject: RE: [PATCH bpf v2] xsk: Fix out of order segment free in
 __xsk_generic_xmit()

It seems that CI tests have failed:

First test_progs failure (test_progs-aarch64-gcc-14):
#610/3 xdp_adjust_tail/xdp_adjust_tail_grow2
...
test_xdp_adjust_tail_grow2:FAIL:case-128 retval unexpected case-128 retval: actual 1 != expected 3
test_xdp_adjust_tail_grow2:FAIL:case-128 data_size_out unexpected case-128 data_size_out: actual 128 != expected 3520
test_xdp_adjust_tail_grow2:FAIL:case-128-data cnt unexpected case-128-data cnt: actual 0 != expected 3392
test_xdp_adjust_tail_grow2:FAIL:case-128-data data_size_out unexpected case-128-data data_size_out: actual 128 != expected 3520
...
#620 xdp_do_redirect
...
test_max_pkt_size:FAIL:prog_run_max_size unexpected error: -22 (errno 22)

But Im not sure why?

My changes impact only AF_XDP generic_xmit functions, these bpf tests don't touch
AF_XDP sockets xmit path. Changes should impact only sendmsg socket syscall.
Most of changes are Translation Unit local to xsk module.
The only thing i think could impact that is skb_shared_info, but why?

xsk tests didn't fail. Could you help me figure it out?
Should I be worried? Maybe tests are broken?