netdev - Re: [Bug] "possible deadlock in rtnl_newlink" in Linux kernel v6.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDkF-Q5K6RhIX5MD@LQ3V64L9R2>
Date: Thu, 29 May 2025 18:12:25 -0700
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jacob Keller <jacob.e.keller@...el.com>, John <john.cs.hey@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Bug] "possible deadlock in rtnl_newlink" in Linux kernel v6.13

On Thu, May 29, 2025 at 05:16:40PM -0700, Jakub Kicinski wrote:
> On Thu, 29 May 2025 16:50:17 -0700 Joe Damato wrote:
> > @@ -1262,6 +1258,11 @@ static void e1000_remove(struct pci_dev *pdev)
> >         bool disable_dev;
> > 
> >         e1000_down_and_stop(adapter);
> > +
> > +       /* Only kill reset task if adapter is not resetting */
> > +       if (!test_bit(__E1000_RESETTING, &adapter->flags))
> > +               cancel_work_sync(&adapter->reset_task);
> > +
> >         e1000_release_manageability(adapter);
> > 
> >         unregister_netdev(netdev);
> 
> LGTM, FWIW.
> For extra points you can move it after the unregister_netdev(),
> the existing code cancels the work but netdev may still be up
> and kick it back in..

Good idea, thanks.

I'll post something to the list, but I don't have a reproducer to
test. I'm a noob with syzbot, but maybe there's a way to trigger it
to re-run with a posted patch?