netdev - Re: [PATCH net] netconsole: Only register console drivers when targets are configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250530193052.1bdbc879@kernel.org>
Date: Fri, 30 May 2025 19:30:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Tejun Heo <tj@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, horms@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net] netconsole: Only register console drivers when
 targets are configured

On Wed, 28 May 2025 10:20:19 -0700 Breno Leitao wrote:
> The netconsole driver currently registers the basic console driver
> unconditionally during initialization, even when only extended targets
> are configured. This results in unnecessary console registration and
> performance overhead, as the write_msg() callback is invoked for every
> log message only to return early when no matching targets are found.
> 
> Optimize the driver by conditionally registering console drivers based
> on the actual target configuration. The basic console driver is now
> registered only when non-extended targets exist, same as the extended
> console. The implementation also handles dynamic target creation through
> the configfs interface.
> 
> This change eliminates unnecessary console driver registrations,
> redundant write_msg() callbacks for unused console types, and associated
> lock contention and target list iterations. The optimization is
> particularly beneficial for systems using only the most common extended
> console type.
> 
> Fixes: e2f15f9a79201 ("netconsole: implement extended console support")

Code makes sense but I think it's net-next material.
-- 
pw-bot: defer