netdev - Re: [PATCH 5/5] io_uring/netcmd: add tx timestamping cmd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505311513.4gHg718O-lkp@intel.com>
Date: Sat, 31 May 2025 16:34:15 +0800
From: kernel test robot <lkp@...el.com>
To: Pavel Begunkov <asml.silence@...il.com>, io-uring@...r.kernel.org,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev, asml.silence@...il.com,
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Willem de Bruijn <willemb@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 5/5] io_uring/netcmd: add tx timestamping cmd support

Hi Pavel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master next-20250530]
[cannot apply to horms-ipvs/master v6.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pavel-Begunkov/net-timestamp-add-helper-returning-skb-s-tx-tstamp/20250530-201922
base:   net/main
patch link:    https://lore.kernel.org/r/2308b0e2574858aeef6837f4f9897560a835e0f7.1748607147.git.asml.silence%40gmail.com
patch subject: [PATCH 5/5] io_uring/netcmd: add tx timestamping cmd support
config: riscv-randconfig-r121-20250531 (https://download.01.org/0day-ci/archive/20250531/202505311513.4gHg718O-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 10.5.0
reproduce: (https://download.01.org/0day-ci/archive/20250531/202505311513.4gHg718O-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505311513.4gHg718O-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   io_uring/cmd_net.c:59:32: sparse: sparse: array of flexible structures
   io_uring/cmd_net.c: note: in included file:
   io_uring/uring_cmd.h:21:59: sparse: sparse: array of flexible structures
>> io_uring/cmd_net.c:94:55: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __poll_t [usertype] mask @@     got int @@
   io_uring/cmd_net.c:94:55: sparse:     expected restricted __poll_t [usertype] mask
   io_uring/cmd_net.c:94:55: sparse:     got int

vim +94 io_uring/cmd_net.c

    81	
    82	static int io_uring_cmd_timestamp(struct socket *sock,
    83					  struct io_uring_cmd *cmd,
    84					  unsigned int issue_flags)
    85	{
    86		struct sock *sk = sock->sk;
    87		struct sk_buff_head *q = &sk->sk_error_queue;
    88		struct sk_buff *skb, *tmp;
    89		struct sk_buff_head list;
    90		int ret;
    91	
    92		if (!(issue_flags & IO_URING_F_CQE32))
    93			return -EINVAL;
  > 94		ret = io_cmd_poll_multishot(cmd, issue_flags, POLLERR);
    95		if (unlikely(ret))
    96			return ret;
    97	
    98		if (skb_queue_empty_lockless(q))
    99			return -EAGAIN;
   100		__skb_queue_head_init(&list);
   101	
   102		scoped_guard(spinlock_irq, &q->lock) {
   103			skb_queue_walk_safe(q, skb, tmp) {
   104				/* don't support skbs with payload */
   105				if (!skb_has_tx_timestamp(skb, sk) || skb->len)
   106					continue;
   107				__skb_unlink(skb, q);
   108				__skb_queue_tail(&list, skb);
   109			}
   110		}
   111	
   112		while (1) {
   113			skb = skb_peek(&list);
   114			if (!skb)
   115				break;
   116			if (!io_process_timestamp_skb(cmd, sk, skb, issue_flags))
   117				break;
   118			__skb_dequeue(&list);
   119			consume_skb(skb);
   120		}
   121	
   122		if (!unlikely(skb_queue_empty(&list))) {
   123			scoped_guard(spinlock_irqsave, &q->lock)
   124				skb_queue_splice(q, &list);
   125		}
   126		return -EAGAIN;
   127	}
   128	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki