netdev - Re: [External] : [PATCH] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc05cbf5-0b59-4442-9585-9658d67f9059@oracle.com>
Date: Mon, 2 Jun 2025 01:21:48 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: bcf@...gle.com, joshwash@...gle.com, willemb@...gle.com,
        pkaligineedi@...gle.com, pabeni@...hat.com, kuba@...nel.org,
        jeroendb@...gle.com, hramamurthy@...gle.com, andrew+netdev@...n.ch,
        davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [External] : [PATCH] gve: add missing NULL check for
 gve_alloc_pending_packet() in TX DQO



On 02-06-2025 01:19, Mina Almasry wrote:
> On Sun, Jun 1, 2025 at 12:34 PM Alok Tiwari <alok.a.tiwari@...cle.com> wrote:
>>
>> gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
>> did not check for this case before dereferencing the returned pointer.
>>
>> Add a missing NULL check to prevent a potential NULL pointer
>> dereference when allocation fails.
>>
>> This improves robustness in low-memory scenarios.
>>
>> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> 
> Patch itself looks good to me, but if you can, please designate it to
> the net tree by prefixing the patch with `[PATCH net v2]` as mentioned
> in our docs:
> 
> https://urldefense.com/v3/__https://docs.kernel.org/process/maintainer-netdev.html__;!!ACWV5N9M2RV99hQ!JPpnRT9itx84rhzAaeGelVD-bnJR8vFksx2OjGzAKZWf_A6o8hEY0CUMMUO_NuSStcCyBGnvhoJAJlADszR4D_aj$
> 
> Also, if possible, add `Fixes: commit a57e5de476be ("gve: DQO: Add TX
> path")` to give it a chance to get picked up by stable trees.
> 
> With that:
> 
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> 


Thanks for your review.

I will send v2 and add Fixes tag.
Thanks,
Alok