netdev - [PATCH net 0/6][pull request] iavf: get rid of the crit lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250603171710.2336151-1-anthony.l.nguyen@intel.com>
Date: Tue,  3 Jun 2025 10:17:01 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: davem@...emloft.net,
	kuba@...nel.org,
	pabeni@...hat.com,
	edumazet@...gle.com,
	andrew+netdev@...n.ch,
	netdev@...r.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
	przemyslaw.kitszel@...el.com,
	sdf@...ichev.me
Subject: [PATCH net 0/6][pull request] iavf: get rid of the crit lock

Przemek Kitszel says:

Fix some deadlocks in iavf, and make it less error prone for the future.

Patch 1 is simple and independent from the rest.
Patches 2, 3, 4 are strictly a refactor, but it enables the last patch
	to be much smaller.
	(Technically Jake given his RB tags not knowing I will send it to -net).
Patch 5 just adds annotations, this also helps prove last patch to be correct.
Patch 6 removes the crit lock, with its unusual try_lock()s.

I have more refactoring for scheduling done for -next, to be sent soon.

There is a simple test:
 add VF; decrease number of queueus; remove VF
that was way too hard to pass without this series :)
---
IWL: https://lore.kernel.org/intel-wired-lan/20250404102321.25846-1-przemyslaw.kitszel@intel.com/

The following are changes since commit b56bbaf8c9ffe02468f6ba8757668e95dda7e62c:
  Merge branch 'net-airoha-fix-ipv6-hw-acceleration'
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 40GbE

Przemek Kitszel (6):
  iavf: iavf_suspend(): take RTNL before netdev_lock()
  iavf: centralize watchdog requeueing itself
  iavf: simplify watchdog_task in terms of adminq task scheduling
  iavf: extract iavf_watchdog_step() out of iavf_watchdog_task()
  iavf: sprinkle netdev_assert_locked() annotations
  iavf: get rid of the crit lock

 drivers/net/ethernet/intel/iavf/iavf.h        |   1 -
 .../net/ethernet/intel/iavf/iavf_ethtool.c    |  29 +-
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 289 ++++++------------
 3 files changed, 96 insertions(+), 223 deletions(-)

-- 
2.47.1