netdev - Re: [PATCH] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANH7hM6qyU4+uEB06FSAiQyitQ8jyuBXzzTD0QkoH7vYca71mw@mail.gmail.com>
Date: Tue, 3 Jun 2025 11:02:18 -0700
From: Bailey Forrest <bcf@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: ALOK TIWARI <alok.a.tiwari@...cle.com>, Eric Dumazet <edumazet@...gle.com>, 
	Mina Almasry <almasrymina@...gle.com>, joshwash@...gle.com, willemb@...gle.com, 
	pkaligineedi@...gle.com, kuba@...nel.org, jeroendb@...gle.com, 
	hramamurthy@...gle.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] gve: add missing NULL check for gve_alloc_pending_packet()
 in TX DQO

On Tue, Jun 3, 2025 at 3:50 AM Paolo Abeni <pabeni@...hat.com> wrote:
> IMHO it's indeed confusing that the same condition is checked in
> gve_alloc_pending_packet() and ignored by gve_tx_add_skb_dqo().
>
> Even gve_alloc_pending_packet() is only called after the
> gve_maybe_stop_tx_dqo().
>
> Either always ignore the NULL condition it in both places (possibly with
> a comment) or always check it.

It's probably not harmful to go ahead with this patch, I agree this
will make it easier for readers.

My point was it's not technically a bug, so it doesn't need (Fixes ...)

If we do make this change we can now remove the comment on gve_tx_add_skb_dqo()

 * Before this function is called, the caller must ensure
 * gve_has_pending_packet(tx) returns true.
 */

Reviewed-by: Bailey Forrest <bcf@...gle.com>