netdev - Re: [PATCH v2 net-next 6/7] socket: Replace most sock_create() calls with sock_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250603045021.GA8367@lst.de>
Date: Tue, 3 Jun 2025 06:50:21 +0200
From: Christoph Hellwig <hch@....de>
To: Kuniyuki Iwashima <kuni1840@...il.com>
Cc: hch@....de, axboe@...nel.dk, chuck.lever@...cle.com,
	davem@...emloft.net, edumazet@...gle.com, horms@...nel.org,
	jaka@...ux.ibm.com, jlayton@...nel.org, kbusch@...nel.org,
	kuba@...nel.org, kuniyu@...zon.com, linux-nfs@...r.kernel.org,
	linux-nvme@...ts.infradead.org, linux-rdma@...r.kernel.org,
	matttbe@...nel.org, mptcp@...ts.linux.dev, netdev@...r.kernel.org,
	pabeni@...hat.com, sfrench@...ba.org, wenjia@...ux.ibm.com,
	willemb@...gle.com
Subject: Re: [PATCH v2 net-next 6/7] socket: Replace most sock_create()
 calls with sock_create_kern().

On Mon, Jun 02, 2025 at 02:52:47PM -0700, Kuniyuki Iwashima wrote:
> From: Christoph Hellwig <hch@....de>
> Date: Mon, 2 Jun 2025 07:09:49 +0200
> > On Thu, May 29, 2025 at 08:03:06PM -0700, Kuniyuki Iwashima wrote:
> > > I actually tried to to do so as sock_create_user() in the
> > > previous series but was advised to avoid rename as the benefit
> > > against LoC was low.
> > 
> > I can't really parse this.  What is the 'benefit against LoC'?
> 
> It was a kind of subjective opinion whether the amount of changes
> was worth or not.

So the simple scripted renaming was not worth it.  Maybe I misunderstand,
but based on the reading we should basically have about a handful
callers of the non-__kern variant left.  Or is it a lot more?