netdev - Re: [PATCH net v2] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250603082506.GZ1484967@horms.kernel.org>
Date: Tue, 3 Jun 2025 09:25:06 +0100
From: Simon Horman <horms@...nel.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: almasrymina@...gle.com, bcf@...gle.com, joshwash@...gle.com,
	willemb@...gle.com, pkaligineedi@...gle.com, pabeni@...hat.com,
	kuba@...nel.org, jeroendb@...gle.com, hramamurthy@...gle.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	darren.kenny@...cle.com
Subject: Re: [PATCH net v2] gve: add missing NULL check for
 gve_alloc_pending_packet() in TX DQO

On Mon, Jun 02, 2025 at 03:34:29AM -0700, Alok Tiwari wrote:
> gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
> did not check for this case before dereferencing the returned pointer.
> 
> Add a missing NULL check to prevent a potential NULL pointer
> dereference when allocation fails.
> 
> This improves robustness in low-memory scenarios.
> 
> Fixes: a57e5de476be ("gve: DQO: Add TX path")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> ---
> v1->v2
> added Fixes tag and [PATCH net v2]

This patch is marked as Rejected in patchwork, but it's unclear to me why.
The patch does look good to me, there was positive review to v1 which
is addressed in v2, and i see no prior comment on v2. I'm updating it's
status accordingly. Apologies if I missed something.

Reviewed-by: Simon Horman <horms@...nel.org>

-- 
pw-bot: under-review