netdev - RE: [Intel-wired-lan] [PATCH iwl-net 0/6] undeadlock iavf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89856149EF29166460C01F0C8F6DA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Tue, 3 Jun 2025 09:29:13 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Stanislav Fomichev
	<sdf@...ichev.me>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 0/6] undeadlock iavf

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Przemek Kitszel
> Sent: Friday, April 4, 2025 12:23 PM
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Cc: netdev@...r.kernel.org; Stanislav Fomichev <sdf@...ichev.me>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net 0/6] undeadlock iavf
> 
> Fix some deadlocks in iavf, and make it less error prone for the future.
> 
> Patch 1 is simple and independed from the rest.
> Patches 2, 3, 4 are strictly a refactor, but it enables the last patch
> 	to be much smaller.
> 	(Technically Jake given his RB tags not knowing I will send it to -net).
> Patch 5 just adds annotations, this also helps prove last patch to be correct.
> Patch 6 removes the crit lock, with its unusual try_lock()s.
> 
> I have more refactoring for scheduling done for -next, to be sent soon.
> 
> There is a simple test:
>  add VF; decrease number of queueus; remove VF that was way too hard to
> pass without this series :)
> 
> Testing hints for VAL:
> whole regression set, both against ice and i40e.
> 
> Przemek Kitszel (6):
>   iavf: iavf_suspend(): take RTNL before netdev_lock()
>   iavf: centralize watchdog requeueing itself
>   iavf: simplify watchdog_task in terms of adminq task scheduling
>   iavf: extract iavf_watchdog_step() out of iavf_watchdog_task()
>   iavf: sprinkle netdev_assert_locked() annotations
>   iavf: get rid of the crit lock
> 
>  drivers/net/ethernet/intel/iavf/iavf.h        |   1 -
>  .../net/ethernet/intel/iavf/iavf_ethtool.c    |  29 +-
>  drivers/net/ethernet/intel/iavf/iavf_main.c   | 289 ++++++------------
>  3 files changed, 96 insertions(+), 223 deletions(-)
> 
> --
> 2.39.3


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>