netdev - Re: [PATCH net-next v2 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f128f83-d4fa-462b-bcd0-2309e3c2c212@redhat.com>
Date: Tue, 3 Jun 2025 13:23:21 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: David J Wilder <wilder@...ibm.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/4] bonding: Extend arp_ip_target format to
 allow for a list of vlan tags.

On 6/3/25 5:51 AM, David J Wilder wrote:
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 1a3d17754c0a..78d41b7b28b5 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -288,13 +288,21 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
>  		bond_option_arp_ip_targets_clear(bond);
>  		nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) {
>  			__be32 target;
> +			char target_str[1024 + 1];

This buffer is too big to be placed on the stack. Also please respect
the reverse christmas tree order.

/p