netdev - Re: [RFC PATCH net-next 1/2] dt-bindings: net: pse-pd: Describe the LTC4266 PSE chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4316518-01d2-45f2-94d8-40ed2028689b@kernel.org>
Date: Wed, 4 Jun 2025 08:43:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyle Swenson <kyle.swenson@....tech>,
 "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
 "kory.maincent@...tlin.com" <kory.maincent@...tlin.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 1/2] dt-bindings: net: pse-pd: Describe the
 LTC4266 PSE chipset

On 04/06/2025 01:04, Kyle Swenson wrote:
> +allOf:
> +  - $ref: pse-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc4266
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#pse-cells':
> +    const: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  channels:
> +

Drop blank line

> +    description: This parameter describes the mapping between the logical ports
> +      on the PSE controller and the physical ports.

Move description after additionalProperties, so entire block is together.

> +

> +    type: object
> +
Drop blank line


> +    additionalProperties: false
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +

Only one blank line

> +    patternProperties:
> +      '^channel@[0-3]$':
> +        type: object
> +        additionalProperties: false
> +
> +        properties:
> +          reg:
> +            maxItems: 1
> +
> +          sense-resistor-micro-ohms:
> +            description: Sense resistor connected to the channel's MOSFET, used
> +              for current measurement for overcurrent detection.
> +            enum: [250000, 500000]
> +
> +        required:
> +          - reg
> +
> +    required:
> +      - "#address-cells"

Keep consistent quotes, either ' or "

> +      - "#size-cells"
> +
> +unevaluatedProperties: false

This goes after required block

> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet-pse@2f {
> +        compatible = "lltc,ltc4266";
> +        status = "okay";

Drop

> +

Drop blank line


> +        reg = <0x2f>;
> +
> +        channels {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          phys0: channel@0 {
> +            reg = <0>;
> +          };
> +
> +          phys1: channel@1 {
> +            reg = <1>;
> +          };
> +
> +          phys2: channel@2 {
> +            reg = <2>;
> +          };
> +
> +          phys3: channel@3 {
> +            reg = <3>;
> +          };
> +        };

Blank line... you really folllow entirely different style :/



Best regards,
Krzysztof