netdev - Re: [PATCH net-next] net: macb: Add shutdown operation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a8bf428-1332-44f9-bb59-321989ec2578@lunn.ch>
Date: Wed, 4 Jun 2025 14:31:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Joseph, Abin" <Abin.Joseph@....com>
Cc: "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
	"claudiu.beznea@...on.dev" <claudiu.beznea@...on.dev>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"git (AMD-Xilinx)" <git@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: macb: Add shutdown operation support

> Yes, I tested this on a device which was admin down using "ifconfig eth0 down".

ifconfig has been deprecated for over a decade. I suggest you stop
using it.

> I observed that macb_close() is invoked only once, specifically when
> the interface is bought down. During the kexec call the shutdown
> hook is triggered, but the close() won't be called In this scenario.

Implementations vary quite a bit, so i have no idea what is actually
correct. But my aesthetic sense is calling dev_close() without a
matching dev_open() up is wrong. Please could you expand the commit
message, because i had a look at some other .shutdown functions and
they are careful to not call dev_close() unless the interface is admin
up.  Some take, RTNL, some don't. So a good commit message which
explaining why you change is correct would be good.

	   Andrew