netdev - Re: [PATCH 1/5] net: timestamp: add helper returning skb's tx tstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68404c4fa8590_1e99f529486@willemb.c.googlers.com.notmuch>
Date: Wed, 04 Jun 2025 09:38:23 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Pavel Begunkov <asml.silence@...il.com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 io-uring@...r.kernel.org, 
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: netdev@...r.kernel.org, 
 Eric Dumazet <edumazet@...gle.com>, 
 Kuniyuki Iwashima <kuniyu@...zon.com>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 1/5] net: timestamp: add helper returning skb's tx tstamp

Pavel Begunkov wrote:
> On 6/2/25 14:31, Willem de Bruijn wrote:
> > Pavel Begunkov wrote:
> >> On 6/1/25 14:52, Willem de Bruijn wrote:
> >>> Pavel Begunkov wrote:
> >>>> Add a helper function skb_get_tx_timestamp() that returns a tx timestamp
> >>>> associated with an skb from an queue queue.
> ...>> ...>> diff --git a/net/socket.c b/net/socket.c
> >>>> index 9a0e720f0859..d1dc8ab28e46 100644
> >>>> --- a/net/socket.c
> >>>> +++ b/net/socket.c
> >>>> @@ -843,6 +843,55 @@ static void put_ts_pktinfo(struct msghdr *msg, struct sk_buff *skb,
> >>>>    		 sizeof(ts_pktinfo), &ts_pktinfo);
> >>>>    }
> >>>>    
> >>>> +bool skb_has_tx_timestamp(struct sk_buff *skb, struct sock *sk)
> >>>
> >>> Here and elsewhere: consider const pointers where possible
> >>
> >> will do
> 
> I constantized the sock pointer in v2 but can't do same with skb as
> skb_hwtstamps() and other helpers don't work with const. I can follow
> up on top preparing those helpers, but to avoid cross tree conflicts
> it's probably better to leave the helpers from this patch without
> const untill all is merged and pulled, hope that's works for you.

Ok. No need to follow up per se.