netdev - Re: [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68404cdc417f3_1e99f529483@willemb.c.googlers.com.notmuch>
Date: Wed, 04 Jun 2025 09:40:44 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 Jakub Kicinski <kuba@...nel.org>, 
 shuah@...nel.org, 
 willemb@...gle.com, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to
 quit

Jakub Kicinski wrote:
> Commit 846742f7e32f ("selftests: drv-net: add a warning for
> bkg + shell + terminate") added a warning for bkg() used
> with terminate=True. The tso test was missed as we didn't
> have it running anywhere in NIPA. Add exit_wait=True, to avoid:
> 
>   # Warning: combining shell and terminate is risky!
>   #          SIGTERM may not reach the child on zsh/ksh!
> 
> getting printed twice for every variant.
> 
> Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>