netdev - Re: [ANN] pylint and shellcheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250605072638.57c56f95@kernel.org>
Date: Thu, 5 Jun 2025 07:26:38 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [ANN] pylint and shellcheck

On Thu, 05 Jun 2025 10:02:10 +0100 Donald Hunter wrote:
> Jakub Kicinski <kuba@...nel.org> writes:
> 
> > On Wed, 04 Jun 2025 10:41:14 +0100 Donald Hunter wrote:  
> >> This is a possible config for yamllint:
> >> 
> >> extends: default
> >> rules:
> >>   document-start: disable
> >>   brackets:
> >>     max-spaces-inside: 1
> >>   comments:
> >>     min-spaces-from-content: 1
> >>   line-length:
> >>     max: 96  
> >
> > This fits our current style pretty nicely!
> >
> > One concern I have is that yamllint walks down the filesystem
> > CWD down to root or home dir. So if we put this in
> > Documentation/netlink/.yamllint people running yamllint from main dir:
> >
> >  $ yamllint Documentation/netlink/specs/netdev.yaml
> >
> > will be given incorrect warnings, no? Is there a workaround?  
> 
> I don't see a workaround without some kind of wrapper.
> 
> Maybe just add a makefile? Looks like that was the approach taken for
> Documentation/devicetree/bindings

If we can live with the document-start annoyance I was wondering 
if we can stick to the "default" as is? We can fix existing
docs slowly, the patchwork script will ignore pre-existing warnings.