netdev - Re: [for-linus][PATCH 3/5] xdp: Remove unused mem_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250605142730.wv5rsc4eg6ynwpga@gmail.com>
Date: Thu, 5 Jun 2025 07:27:30 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev <netdev@...r.kernel.org>,
	Jonathan Lemon <jonathan.lemon@...il.com>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [for-linus][PATCH 3/5] xdp: Remove unused mem_return_failed event

On 2025-06-03 13:11:52, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The change to allow page_pool to handle its own page destruction instead
> of relying on XDP removed the trace_mem_return_failed() tracepoint caller,
> but did not remove the mem_return_failed trace event. As trace events take
> up memory when they are created regardless of if they are used or not,
> having this unused event around wastes around 5K of memory.
> 
> Remove the unused event.
> 
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> 
> Cc: netdev <netdev@...r.kernel.org>
> Cc: Jonathan Lemon <jonathan.lemon@...il.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Link: https://lore.kernel.org/20250529160550.1f888b15@gandalf.local.home
> Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  include/trace/events/xdp.h | 26 --------------------------
>  1 file changed, 26 deletions(-)

Reviewed-by: John Fastabend <john.fastabend@...il.com>