netdev - Re: [PATCH v3] net/mlx5: Flag state up only after cmdif is ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7a8e85ea-7ce3-4da4-bb0b-819fe9f7d54b@nvidia.com>
Date: Thu, 5 Jun 2025 11:14:46 +0300
From: Moshe Shemesh <moshe@...dia.com>
To: 赵晨光 <zhaochenguang@...inos.cn>, Saeed Mahameed
	<saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan
	<tariqt@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: netdev <netdev@...r.kernel.org>, linux-rdma <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH v3] net/mlx5: Flag state up only after cmdif is ready

On 6/4/2025 6:07 AM, 赵晨光 wrote:
> 
> The trace points to cmdif, that's why we better handle it there.
> I couldn't reproduce it using the scripts above, what is the
> reproduction frequency ? can you send me the whole log of reproduction ?
> See the attachment for all logs.
> Thanks!

Thanks for the logs and the data.

As I see, this is a reproduction on old OFED 4.7-3.2.9 driver, while on 
new upstream driver we have mlx5_cmdif_state checked in cmd_exec() which 
means to avoid such trace by setting mlx5_cmdif_state down on 
mlx5_function_teardown() and up only after mlx5_cmd_enable() which do 
create_msg_cache(). You can also check on latest OFED and if issue 
reproduced there, please take it with Nvidia support. If you have 
reproduction on latest upstream kernel driver, please send the 
reproduction log and we can continue here till resolved upstream.