netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: add a separate Rx handler for flow director commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898535863FD9575698F7565C8F6FA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 5 Jun 2025 08:18:30 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Kubiak, Michal" <michal.kubiak@...el.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Swiatkowski, Michal"
	<michal.swiatkowski@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: add a separate Rx
 handler for flow director commands

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal
> Kubiak
> Sent: Thursday, May 15, 2025 11:47 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; netdev@...r.kernel.org; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; horms@...nel.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Swiatkowski, Michal
> <michal.swiatkowski@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: add a separate Rx handler
> for flow director commands
> 
> On Wed, May 14, 2025 at 01:50:22PM -0700, Jacob Keller wrote:
> >
> >
> > On 5/14/2025 5:37 AM, Michal Kubiak wrote:
> > > The "ice" driver implementation uses the control VSI to handle the
> > > flow director configuration for PFs and VFs.
> > >
> > > Unfortunately, although a separate VSI type was created to handle
> > > flow director queues, the Rx queue handler was shared between the
> > > flow director and a standard NAPI Rx handler.
> > >
> > > Such a design approach was not very flexible. First, it mixed
> > > hotpath and slowpath code, blocking their further optimization. It
> > > also created a huge overkill for the flow director command
> > > processing, which is descriptor-based only, so there is no need to allocate Rx
> data buffers.
> > >
> > > For the above reasons, implement a separate Rx handler for the
> > > control VSI. Also, remove from the NAPI handler the code dedicated
> > > to configuring the flow director rules on VFs.
> > > Do not allocate Rx data buffers to the flow director queues because
> > > their processing is descriptor-based only.
> > > Finally, allow Rx data queues to be allocated only for VSIs that
> > > have netdev assigned to them.


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>