netdev - Re: [PATCH v2] net: enetc: fix the netc-lib driver build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250605123704.iiavrsaz3pj4ursj@skbuf>
Date: Thu, 5 Jun 2025 15:37:04 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Wei Fang <wei.fang@....com>
Cc: Claudiu Manoil <claudiu.manoil@....com>,
	Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"arnd@...nel.org" <arnd@...nel.org>
Subject: Re: [PATCH v2] net: enetc: fix the netc-lib driver build dependency

On Thu, Jun 05, 2025 at 02:05:47PM +0300, Wei Fang wrote:
> > I think you slightly misunderstood Arnd's suggestion. NXP_NTMP was named
> > "NXP_NETC_NTMP" in his proposal, and it meant "does FSL_ENETC_CORE need
> > the functionality from NXP_NETC_LIB?".
> > 
> > The switch driver shouldn't need to select NXP_NTMP. Just NXP_NETC_LIB.
> > 
> 
> For the case :NXP_ENET4=n , FSL_ENETC=y and NXP_NETC_SWITCH=m, if the
> switch driver only selects NXP_NETC_LIB, then the netc-lib driver will be compiled
> as a module. So the issue will be reported again. And Arnd also said "The switch
> module can then equally enable bool symbol."
> 
> > I don't agree with removing "NETC" from NXP_NETC_NTMP, I think it helps
> > clarify that the option pertains just to the NETC drivers.
> 
> NTMP means " NETC Table Management Protocol", I don't know why we need
> to add a 'NETC' again, it does not make sense to me.

Understood, thanks for the example. It was me who misunderstood. In that case

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>