netdev - Re: [PATCH V2] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN6PR1901MB46541BA6488F73EB49EBCDDFA56EA@SN6PR1901MB4654.namprd19.prod.outlook.com>
Date: Fri, 6 Jun 2025 09:44:48 -0500
From: Chris Morgan <macromorgan@...mail.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Chris Morgan <macroalpha82@...il.com>, netdev@...r.kernel.org,
	linux@...linux.org.uk, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH V2] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick

On Fri, Jun 06, 2025 at 02:53:46PM +0200, Andrew Lunn wrote:
> On Thu, Jun 05, 2025 at 09:22:03PM -0500, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@...mail.com>
> > 
> > Add quirk for Potron SFP+ XGSPON ONU Stick (YV SFP+ONT-XGSPON).
> > 
> > This device uses pins 2 and 7 for UART communication, so disable
> > TX_FAULT and LOS. Additionally as it is an embedded system in an
> > SFP+ form factor provide it enough time to fully boot before we
> > attempt to use it.
> > 
> > https://www.potrontec.com/index/index/list/cat_id/2.html#11-83
> > https://pon.wiki/xgs-pon/ont/potron-technology/x-onu-sfpp/
> > 
> > Signed-off-by: Chris Morgan <macromorgan@...mail.com>
> > ---
> > 
> > Changes since V1:
> >  - Call sfp_fixup_ignore_tx_fault() and sfp_fixup_ignore_los() instead
> >    of setting the state_hw_mask.
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
> You are supposed to wait 24 hours before posting a new version. We are
> also in the merge window at the moment, so please post patches as RFC.

Sorry, I'll make sure to slow down the commits moving forward.

> 
> Russell asked the question, what does the SFP report about soft LOS in
> its EEPROM? Does it correctly indicate it supports soft LOS? Does it
> actually support soft LOS? Do we need to force on soft LOS? Maybe we
> need a helper sfp_fixup_force_soft_los()?

So I'm a bit out of my element here and not sure how to check that. I
bought this module and had a hell of a time getting it to work on my
Banana Pi R4 because of the UART triggering repeated tx faults. After
applying these updates I was able to get it to work, so I figured it
would be a courtesy to upstream these for others not to suffer. I was
going to get this upstreamed, then request OpenWRT backport the fix,
then move this device to replace my current router (which might be why
I am guilty of rushing, sorry again). That said, I'm not sure how to
check if the module supports soft LOS or not. I did a dump with
ethtool -m but didn't see any references to LOS. Is there a bit on the
EEPROM I can check?

Thank you,
Chris

> 
>     Andrew
> 
> ---
> pw-bot: cr