| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <IA3PR11MB8986C1AECE9F09A36FB37D3BE56BA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 9 Jun 2025 18:56:01 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Stanislav Fomichev <stfomichev@...il.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>, "skalluru@...vell.com"
<skalluru@...vell.com>, "manishc@...vell.com" <manishc@...vell.com>,
"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "michael.chan@...adcom.com"
<michael.chan@...adcom.com>, "pavan.chebbi@...adcom.com"
<pavan.chebbi@...adcom.com>, "ajit.khaparde@...adcom.com"
<ajit.khaparde@...adcom.com>, "sriharsha.basavapatna@...adcom.com"
<sriharsha.basavapatna@...adcom.com>, "somnath.kotur@...adcom.com"
<somnath.kotur@...adcom.com>, "Nguyen, Anthony L"
<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
<przemyslaw.kitszel@...el.com>, "tariqt@...dia.com" <tariqt@...dia.com>,
"saeedm@...dia.com" <saeedm@...dia.com>, "louis.peens@...igine.com"
<louis.peens@...igine.com>, "shshaikh@...vell.com" <shshaikh@...vell.com>,
"GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
"ecree.xilinx@...il.com" <ecree.xilinx@...il.com>, "horms@...nel.org"
<horms@...nel.org>, "dsahern@...nel.org" <dsahern@...nel.org>,
"shuah@...nel.org" <shuah@...nel.org>, "mheib@...hat.com" <mheib@...hat.com>,
"ruanjinjie@...wei.com" <ruanjinjie@...wei.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"oss-drivers@...igine.com" <oss-drivers@...igine.com>,
"linux-net-drivers@....com" <linux-net-drivers@....com>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
"leon@...nel.org" <leon@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next v2 3/4] netdevsim: remove
udp_ports_sleep
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Stanislav Fomichev
> Sent: Monday, June 9, 2025 6:26 PM
> To: netdev@...r.kernel.org
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; skalluru@...vell.com; manishc@...vell.com;
> andrew+netdev@...n.ch; michael.chan@...adcom.com;
> pavan.chebbi@...adcom.com; ajit.khaparde@...adcom.com;
> sriharsha.basavapatna@...adcom.com; somnath.kotur@...adcom.com;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; tariqt@...dia.com; saeedm@...dia.com;
> louis.peens@...igine.com; shshaikh@...vell.com; GR-Linux-NIC-
> Dev@...vell.com; ecree.xilinx@...il.com; horms@...nel.org;
> dsahern@...nel.org; shuah@...nel.org; mheib@...hat.com;
> ruanjinjie@...wei.com; stfomichev@...il.com; linux-
> kernel@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; linux-
> rdma@...r.kernel.org; oss-drivers@...igine.com; linux-net-
> drivers@....com; linux-kselftest@...r.kernel.org; leon@...nel.org
> Subject: [Intel-wired-lan] [PATCH net-next v2 3/4] netdevsim: remove
> udp_ports_sleep
>
> Now that there is only one path in udp_tunnel, there is no need to
> have udp_ports_sleep knob. Remove it and adjust the test.
>
> Cc: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Stanislav Fomichev <stfomichev@...il.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> drivers/net/netdevsim/netdevsim.h | 2 --
> drivers/net/netdevsim/udp_tunnels.c | 8 --------
> .../selftests/drivers/net/netdevsim/udp_tunnel_nic.sh | 10 ---------
> -
> 3 files changed, 20 deletions(-)
>
> diff --git a/drivers/net/netdevsim/netdevsim.h
> b/drivers/net/netdevsim/netdevsim.h
> index d04401f0bdf7..511ed72a93ce 100644
> --- a/drivers/net/netdevsim/netdevsim.h
> +++ b/drivers/net/netdevsim/netdevsim.h
> @@ -131,7 +131,6 @@ struct netdevsim {
> struct nsim_macsec macsec;
> struct {
> u32 inject_error;
> - u32 sleep;
> u32 __ports[2][NSIM_UDP_TUNNEL_N_PORTS];
> u32 (*ports)[NSIM_UDP_TUNNEL_N_PORTS];
> struct dentry *ddir;
> @@ -342,7 +341,6 @@ struct nsim_dev {
> bool ipv4_only;
> bool shared;
> bool static_iana_vxlan;
> - u32 sleep;
> } udp_ports;
> struct nsim_dev_psample *psample;
> u16 esw_mode;
> diff --git a/drivers/net/netdevsim/udp_tunnels.c
> b/drivers/net/netdevsim/udp_tunnels.c
> index 10cbbf1c584b..89fff76e51cf 100644
> --- a/drivers/net/netdevsim/udp_tunnels.c
> +++ b/drivers/net/netdevsim/udp_tunnels.c
> @@ -18,9 +18,6 @@ nsim_udp_tunnel_set_port(struct net_device *dev,
> unsigned int table,
> ret = -ns->udp_ports.inject_error;
> ns->udp_ports.inject_error = 0;
>
> - if (ns->udp_ports.sleep)
> - msleep(ns->udp_ports.sleep);
> -
> if (!ret) {
> if (ns->udp_ports.ports[table][entry]) {
> WARN(1, "entry already in use\n");
> @@ -47,8 +44,6 @@ nsim_udp_tunnel_unset_port(struct net_device *dev,
> unsigned int table,
> ret = -ns->udp_ports.inject_error;
> ns->udp_ports.inject_error = 0;
>
> - if (ns->udp_ports.sleep)
> - msleep(ns->udp_ports.sleep);
> if (!ret) {
> u32 val = be16_to_cpu(ti->port) << 16 | ti->type;
>
> @@ -170,7 +165,6 @@ int nsim_udp_tunnels_info_create(struct nsim_dev
> *nsim_dev,
> GFP_KERNEL);
> if (!info)
> return -ENOMEM;
> - ns->udp_ports.sleep = nsim_dev->udp_ports.sleep;
>
> if (nsim_dev->udp_ports.sync_all) {
> info->set_port = NULL;
> @@ -213,6 +207,4 @@ void nsim_udp_tunnels_debugfs_create(struct
> nsim_dev *nsim_dev)
> &nsim_dev->udp_ports.shared);
> debugfs_create_bool("udp_ports_static_iana_vxlan", 0600,
> nsim_dev->ddir,
> &nsim_dev->udp_ports.static_iana_vxlan);
> - debugfs_create_u32("udp_ports_sleep", 0600, nsim_dev->ddir,
> - &nsim_dev->udp_ports.sleep);
> }
> diff --git
> a/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> b/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> index 92c2f0376c08..8c5fe7bdf1ce 100755
> --- a/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> +++ b/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> @@ -266,7 +266,6 @@ for port in 0 1; do
> echo $NSIM_ID > /sys/bus/netdevsim/new_device
> else
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> echo 1 > $NSIM_DEV_SYS/new_port
> fi
> NSIM_NETDEV=`get_netdev_name old_netdevs` @@ -350,7 +349,6 @@
> old_netdevs=$(ls /sys/class/net)
> port=0
> echo $NSIM_ID > /sys/bus/netdevsim/new_device echo 0 >
> $NSIM_DEV_SYS/del_port -echo 1000 > $NSIM_DEV_DFS/udp_ports_sleep
> echo 0 > $NSIM_DEV_SYS/new_port NSIM_NETDEV=`get_netdev_name
> old_netdevs`
>
> @@ -428,7 +426,6 @@ echo 0 > $NSIM_DEV_SYS/del_port for port in 0 1;
> do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -486,7 +483,6 @@ echo 1 >
> $NSIM_DEV_DFS/udp_ports_sync_all for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -543,7 +539,6 @@ echo 0 >
> $NSIM_DEV_SYS/del_port for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -573,7 +568,6 @@ echo 1 >
> $NSIM_DEV_DFS/udp_ports_ipv4_only for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -634,7 +628,6 @@ echo 0 >
> $NSIM_DEV_SYS/del_port for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -690,7 +683,6 @@ echo 0 >
> $NSIM_DEV_SYS/del_port for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -750,7 +742,6 @@ echo 0 >
> $NSIM_DEV_SYS/del_port for port in 0 1; do
> if [ $port -ne 0 ]; then
> echo 1 > $NSIM_DEV_DFS/udp_ports_open_only
> - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep
> fi
>
> echo $port > $NSIM_DEV_SYS/new_port @@ -809,7 +800,6 @@ echo
> $NSIM_ID > /sys/bus/netdevsim/new_device echo 0 >
> $NSIM_DEV_SYS/del_port
>
> echo 0 > $NSIM_DEV_DFS/udp_ports_open_only -echo 1 >
> $NSIM_DEV_DFS/udp_ports_sleep echo 1 > $NSIM_DEV_DFS/udp_ports_shared
>
> old_netdevs=$(ls /sys/class/net)
> --
> 2.49.0
Powered by blists - more mailing lists