netdev - Re: [RFC net-next 0/6] net: ethtool: support including Flow Label in the flow hash for RSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7f7a711-cbe0-4003-bdbe-f4db041e90d0@lunn.ch>
Date: Mon, 9 Jun 2025 21:30:53 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: michael.chan@...adcom.com, pavan.chebbi@...adcom.com,
	willemdebruijn.kernel@...il.com, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [RFC net-next 0/6] net: ethtool: support including Flow Label in
 the flow hash for RSS

On Mon, Jun 09, 2025 at 11:58:25AM -0700, Jakub Kicinski wrote:
> On Mon, 9 Jun 2025 20:26:14 +0200 Andrew Lunn wrote:
> > On Mon, Jun 09, 2025 at 10:34:36AM -0700, Jakub Kicinski wrote:
> > > Add support for using IPv6 Flow Label in Rx hash computation
> > > and therefore RSS queue selection.  
> > 
> > It took me a while to get there, i wondered why you are extending the
> > IOCTL code, rather than netlink. But netlink ethtool does not appear
> > to support ops->set_rxnfc() calls.
> > 
> > Rather than extend the deprecated ioctl i think the first patch in the
> > series should add set_rxnfc() to netlink ethtool.
> 
> I suppose the fact we added at least 2 features to this API since 
> the netlink conversion will not convince you otherwise? (input_xfrm
> with all of its options, and GTP flow types and hashing)

Not really. We should of asked that the first patch in those series
added the netlink code. Why did we bother adding netlink, if we are
going to keep extending the IOCTL interface?

	Andrew