netdev - Re: [PATCH net-next] net: ppp: remove error variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250609123701.436aaf43@kernel.org>
Date: Mon, 9 Jun 2025 12:37:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Li Jun <lijun01@...inos.cn>
Cc: davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org,
 michal.swiatkowski@...ux.intel.com, horms@...nel.org
Subject: Re: [PATCH net-next] net: ppp: remove error variable

On Mon,  9 Jun 2025 08:51:43 +0800 Li Jun wrote:
> the error variable did not function as a variable.
> so remove it.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl`` warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject