netdev - Re: [PATCH net v2] net: clear the dst when changing skb protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609145928.014a72c6@kernel.org>
Date: Mon, 9 Jun 2025 14:59:28 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Maciej Żenczykowski <maze@...gle.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, Daniel Borkmann
 <daniel@...earbox.net>, martin.lau@...ux.dev, john.fastabend@...il.com,
 eddyz87@...il.com, sdf@...ichev.me, haoluo@...gle.com, willemb@...gle.com,
 william.xuanziyang@...wei.com, alan.maguire@...cle.com,
 bpf@...r.kernel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org,
 yonghong.song@...ux.dev
Subject: Re: [PATCH net v2] net: clear the dst when changing skb protocol

On Sat, 7 Jun 2025 23:33:39 +0200 Maciej Żenczykowski wrote:
> 1 meta question: as this is a fix and will thus be backported into
> 5.4+ LTS, should this be split into two patches? Either making the
> test a follow up, or even going with only the crash fix in patch 1 and
> putting the 4-in-4 and 6-in-6 behavioural change in patch 2?  We'd end
> up in the same state at tip of tree... but it would affect the LTS
> backports.  Honestly I'm not even sure what's best.

:) Did we go from wondering if we can strip dst unconditionally to
wondering if stripping it on encap/decap may introduce regressions?

I suppose it may be useful to split, just to make it clear which
portion of the change is the crash fix and which one is just because
we think it's more consistent.
-- 
pw-bot: cr