[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK-6q+i+Feb9+_S_yF9h1+bezyfkCh-qrNXcQjsiXjrLHnwLmg@mail.gmail.com>
Date: Sun, 8 Jun 2025 21:34:12 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Ramon Fontes <ramonreisfontes@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
linux-wpan@...r.kernel.org, alex.aring@...il.com, miquel.raynal@...tlin.com,
netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: allow users to specify the number of
simulated radios dynamically instead of the previously hardcoded value of 2
On Sun, Jun 8, 2025 at 12:47 PM Ramon Fontes <ramonreisfontes@...il.com> wrote:
>
> Add a module parameter `radios` to allow users to configure the number
> of virtual radios created by mac802154_hwsim at module load time.
> This replaces the previously hardcoded value of 2.
>
> * Added a new module parameter `radios`
> * Modified the loop in hwsim_probe()
> * Updated log message in hwsim_probe()
>
> Signed-off-by: Ramon Fontes <ramonreisfontes@...il.com>
> ---
> drivers/net/ieee802154/mac802154_hwsim.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index 1cab20b5a..8fcf8a549 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -27,6 +27,10 @@
> MODULE_DESCRIPTION("Software simulator of IEEE 802.15.4 radio(s) for mac802154");
> MODULE_LICENSE("GPL");
>
> +static unsigned int radios = 2;
> +module_param(radios, uint, 0444);
> +MODULE_PARM_DESC(radios, "Number of simulated radios");
> +
> static LIST_HEAD(hwsim_phys);
> static DEFINE_MUTEX(hwsim_phys_lock);
>
> @@ -1018,13 +1022,13 @@ static int hwsim_probe(struct platform_device *pdev)
> struct hwsim_phy *phy, *tmp;
> int err, i;
>
> - for (i = 0; i < 2; i++) {
> + for (i = 0; i < radios; i++) {
> err = hwsim_add_one(NULL, &pdev->dev, true);
> if (err < 0)
> goto err_slave;
> }
>
> - dev_info(&pdev->dev, "Added 2 mac802154 hwsim hardware radios\n");
> + dev_info(&pdev->dev, "Added %d mac802154 hwsim hardware radios\n", radios);
%u ?
- Alex
Powered by blists - more mailing lists