netdev - RE: [Intel-wired-lan] [PATCH v3 2/2] i40e: retry VFLR handling if there is ongoing VF reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8985D1CF724D92AEFA5E0B2C8F6BA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Mon, 9 Jun 2025 07:12:43 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Robert Malz <robert.malz@...onical.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"sylwesterx.dziedziuch@...el.com" <sylwesterx.dziedziuch@...el.com>,
	"mateusz.palczewski@...el.com" <mateusz.palczewski@...el.com>, "Keller, Jacob
 E" <jacob.e.keller@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v3 2/2] i40e: retry VFLR handling if
 there is ongoing VF reset

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Robert
> Malz
> Sent: Tuesday, May 20, 2025 10:32 AM
> To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; sylwesterx.dziedziuch@...el.com;
> mateusz.palczewski@...el.com; Keller, Jacob E <jacob.e.keller@...el.com>
> Subject: [Intel-wired-lan] [PATCH v3 2/2] i40e: retry VFLR handling if there is
> ongoing VF reset
> 
> When a VFLR interrupt is received during a VF reset initiated from a different
> source, the VFLR may be not fully handled. This can leave the VF in an undefined
> state.
> To address this, set the I40E_VFLR_EVENT_PENDING bit again during VFLR
> handling if the reset is not yet complete. This ensures the driver will properly
> complete the VF reset in such scenarios.
> 
> Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered on another VF")
> Signed-off-by: Robert Malz <robert.malz@...onical.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 22d5b1ec2289..88e6bef69342 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -4328,7 +4328,10 @@ int i40e_vc_process_vflr_event(struct i40e_pf *pf)
>  		reg = rd32(hw, I40E_GLGEN_VFLRSTAT(reg_idx));
>  		if (reg & BIT(bit_idx))
>  			/* i40e_reset_vf will clear the bit in GLGEN_VFLRSTAT */
> -			i40e_reset_vf(vf, true);
> +			if (!i40e_reset_vf(vf, true)) {
> +				/* At least one VF did not finish resetting, retry
> next time */
> +				set_bit(__I40E_VFLR_EVENT_PENDING, pf-
> >state);
> +			}
>  	}
> 
>  	return 0;
> --
> 2.34.1


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>