netdev - Re: [PATCH 6.6.y] Revert "mctp: no longer rely on net->dev_index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJd5FZiOyaHEDrESsZ8h+N7ngfkCNnTRNULxV+xM+qMQg@mail.gmail.com>
Date: Mon, 9 Jun 2025 06:26:17 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Jeremy Kerr <jk@...econstruct.com.au>
Cc: Sasha Levin <sashal@...nel.org>, Matt Johnston <matt@...econstruct.com.au>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, Patrick Williams <patrick@...cx.xyz>, 
	Peter Yin <peteryin.openbmc@...il.com>
Subject: Re: [PATCH 6.6.y] Revert "mctp: no longer rely on net->dev_index_head[]"

On Sun, Jun 8, 2025 at 9:12 PM Jeremy Kerr <jk@...econstruct.com.au> wrote:
>
> This reverts commit 2d45eeb7d5d7019b623d513be813123cd048c059 from the
> 6.6 stable tree.
>
> 2d45eeb7d5d7 is the 6.6.y backport of mainline 2d20773aec14.
>
> The switch to for_each_netdev_dump() was predicated on a change in
> semantics for the netdev iterator, introduced by f22b4b55edb5 ("net:
> make for_each_netdev_dump() a little more bug-proof"). Without that
> prior change, we incorrectly repeat the last iteration indefinitely.
>
> 2d45eeb was pulled in to stable as context for acab78ae12c7 ("net: mctp:
> Don't access ifa_index when missing"), but we're fine without it here,
> with a small tweak to the variable declarations as updated patch
> context.
>
> Signed-off-by: Jeremy Kerr <jk@...econstruct.com.au>
> ---
> The 6.6.y branch is the only stable release that has the conversion to
> for_each_netdev_dump() but not the prereq fix to for_each_netdev_dump().

I would rather make sure f22b4b55edb5 ("net: make
for_each_netdev_dump() a little more bug-proof")
is backported to kernels using for_each_netdev_dump()