netdev - Re: [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a6798b9-5e6a-47fc-8217-d7907e0f8720@blackwall.org>
Date: Tue, 10 Jun 2025 15:20:29 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, David Ahern <dsahern@...il.com>,
 netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats
 attributes

On 6/9/25 19:05, Petr Machata wrote:
> ipstats_stat_desc_show_xstats() operates by first parsing the attribute
> stream into a type-indexed table, and then accessing the right attribute.
> But bridge VLAN stats are given as several BRIDGE_XSTATS_VLAN attributes,
> one per VLAN. With the above approach to parsing, only one of these
> attributes would be shown. Instead, iterate the stream of attributes and
> call the show_cb for each one with a matching type.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
> 
> Notes:
>      v2:
>      - Use rtattr_for_each_nested
>      - Drop #include <alloca.h>, it's not used anymore
> 
>   ip/ipstats.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>