lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aEiSxq6lNNJq5DJM@smile.fi.intel.com> Date: Tue, 10 Jun 2025 23:17:10 +0300 From: Andy Shevchenko <andriy.shevchenko@...el.com> To: Laurent Pinchart <laurent.pinchart@...asonboard.com> Cc: Dan Carpenter <dan.carpenter@...aro.org>, "zhangzekun (A)" <zhangzekun11@...wei.com>, Oleksij Rempel <o.rempel@...gutronix.de>, robh@...nel.org, saravanak@...gle.com, justin.chen@...adcom.com, florian.fainelli@...adcom.com, andrew+netdev@...n.ch, kuba@...nel.org, kory.maincent@...tlin.com, jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com, maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com, olteanv@...il.com, davem@...emloft.net, taras.chornyi@...ision.eu, edumazet@...gle.com, pabeni@...hat.com, sudeep.holla@....com, cristian.marussi@....com, arm-scmi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-media@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, chenjun102@...wei.com, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, Krzysztof Kozlowski <krzk@...nel.org> Subject: Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced() On Tue, Jun 10, 2025 at 11:03:39PM +0300, Laurent Pinchart wrote: > On Tue, Jun 10, 2025 at 10:39:31PM +0300, Andy Shevchenko wrote: > > On Fri, Apr 25, 2025 at 08:07:32PM +0300, Laurent Pinchart wrote: > > > On Fri, Apr 25, 2025 at 06:30:10PM +0300, Dan Carpenter wrote: > > > > Whatever happened with this thread from Feb. > > > > https://lore.kernel.org/all/20250207013117.104205-1-zhangzekun11@huawei.com/ > > > > > > > > The issue was that people weren't expecting of_find_node_by_name() to > > > > drop the reference on the of_node. The patchset introduced a wrapper > > > > which basically worked as expected except no liked the naming. Krzysztof > > > > suggested that maybe the callers should be using of_get_child_by_name() > > > > instead. > > > > > > My conclusion is that most of the users of of_find_node_by_name() with a > > > non-NULL first argument are wrong, and should be replaced by > > > of_get_child_by_name(). We need a volunteer to do that work. > > > > Wouldn't be coccinelle a good worker for this job done? > > It's not mechanical work, every single user need to be audited manually. Sure, but at least it can do some job that can be done automatically. > Finding the call sites is the easy part, and we have them already. > > > > I created a Smatch warning for this and here are the four issues it > > > > found. The line numbers are from linux-next. > > > > > > > > drivers/net/ethernet/broadcom/asp2/bcmasp.c:1370 bcmasp_probe() warn: 'dev->of_node' was not incremented > > > > drivers/net/pse-pd/tps23881.c:505 tps23881_get_of_channels() warn: 'priv->np' was not incremented > > > > drivers/media/platform/qcom/venus/core.c:301 venus_add_video_core() warn: 'dev->of_node' was not incremented > > > > drivers/regulator/tps6594-regulator.c:618 tps6594_regulator_probe() warn: 'tps->dev->of_node' was not incremented -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists